Lit: a light engine

(Jacob Albano) #22

Did you add more than one instance? If not, there’s only one instance.

I think the real problem is probably that you’re still running at 1080p.

(Alex Larioza) #23

@jacobalbano Totally missed the resolution on those screen shots…there’s a good chance that’s part of the issue.

@John_Andersson1 I have no way of counting them from my lib, you’d need to look through your code and mare sure that you aren’t adding more than one instance of the lighting object or multiple copies of the same light source by accident.

(John Andersson) #24

The game is not in 1080p, this is another game I’ve recently started with. It’s very very upscaled, so that can’t be the issue. I love your lighting engine, it looks so awesome… wish I could use it. But I have no idea what is wrong!

I’ve provided the only code I have which generates light… which is what I posted earlier, but cut up

do you want the full source code?

(Alex Larioza) #25

Anything relevant to the lighting lib would be helpful.

(John Andersson) #26

Well, what I posted is the only code which I use with the lighting lib…

And for some reason, now when I try to re-add everything, there is no change to the game. Not even if I only add

		add(lighting = new Lighting(FP.screen.width, FP.screen.height));

The screen isn’t black as usual :l

(Tom Rigby) #27

I’ve been using Lit for a while, but I’ve come across a problem that I hope someone can help with. If I move the camera, everything that doesn’t have a light on it is black. Obviously this makes sense - but is there a way of restricting the area of darkness to just a specific location?

The scenario is that I’ve got a building that’s affected by the lighting, but everything else should just have no lighting whatsoever.

(Alex Larioza) #28

@John_Andersson1 You really need to post the whole source code because you haven’t been posting code that has been helpful in solving your problem.

@trig So you only want the lighting inside a rectangular area? The lib doesn’t naively support that - you’d need to experiment with modifications to the lighting class so that it only renders lights within a rectangular area.

(Tom Rigby) #29

Yeah I’ve been trying various things and not having much luck. I just wondered if anyone had any ideas. I’ll keep trying!

(Tom Rigby) #30

I think I’ve fixed it - let me know if this is INSANE. What I’ve done is set all the lights’ scrollX and scrollY to 0, so they don’t move with the camera. THEN, in the lighting update, I have a matrix that has the tx and ty values set to the inverse of the camera. This is then applied during the drawing, moving the entire lighting area.

It seems to work ok… It just seems mad.

(Alex Larioza) #31

That is a bit overkill. What you probably should do is restrict the drawing to the lighting class’s canvas to a rectangular area.

EDIT: if you take a look at the update function in the lighting class you’ll see I only have it updating the rectangular area that the camera is currently looking at. You can use the same method, you just need to set it to the position/size that you need.

(Tom Rigby) #32

I’m sorry I’m being a bit thick (it’s been a long day) - could you point out exactly where that is? I can see where you’re culling any lights that aren’t on screen, but what I’m doing is slightly different.

It’s the FP.buffer.draw method that draws the black (with holes in it for lights). I don’t see a way to restrict this to a worldspace coordinate…?

(thanks!)

(To be honest my ludicrous method doesn’t seem to affect the framerate at all on my low-spec machine, so even if I don’t find a better solution, it’ll do. I’ve written worse code.)

(Alex Larioza) #33

Sorry I actually didnt have it setup like I thought I did, I wrote this little library awhile ago.

However, in the render function you can see how I’m filling the entire canvas:

_canvas.fillRect(_canvas.rect, _fillColor);

Instead of filling the entire canvas (_canvas.rect) you’d just specify the area where your building is. That way only that rectangular area is being filled with your fill color.

(Tom Rigby) #34

Ah of course, I see what you mean! I’ll try that out when I get home. Thanks very much!

(John Andersson) #35

Ok… here I go again.

Gameworld:

package game { import lit.*;

public class GameWorld extends World
{
	[Embed(source="../assets/graphics/lighting/circle.png")]public static const SPR_LIGHT_CIRCLE:Class;
	
	public var lighting:Lighting;
	//public var mouseLight:Light;
	
	public function GameWorld(tileset:Class)
	{

	}
	
	override public function begin():void
	{
		super.begin();
		
		add(lighting = new Lighting(FP.screen.width, FP.screen.height));
		
		loadLevel(blabla, blabla);
	}

	public function loadLevel(levelNumber:Class, tileset:Class):void
	{

		for each (var layer:XML in mapXML.layer)
		{
			var XMLlayers:String = layer.attribute("name");
			switch (XMLlayers)
			{
				case "Background": 
					tileX = 0;
					tileY = 0;
					for each (tile in layer.data.tile)
					{
						if (tileX >= mapWidth)
						{
							tileX = 0;
							tileY++;
						}
						
						if (tile.@gid != 0 && tile.@gid != GID_torch_1 && tile.@gid != GID_torch_2)
						{
							_map_background.setTile(tileX, tileY, uint(tile.@gid - 1));
						}
						
						if (tile.@gid == GID_torch_1)
						{
							var image:Image = new Image(SPR_LIGHT_CIRCLE);
							image.centerOO();
			
							FP.world.add(new Torch(new Point(int(tileX * 16), int(tileY * 16 ))));
							lighting.add(new Light(tileX * 16 + 8, tileY * 16 + 16, image));
							trace("light added")
						}
						
						tileX++;
					}
					break;					
			}
		}

	}
	//End
}

}

I removed everything which isn’t related to the lighting engine

The torch class is just a visual entity.

(Jacob Albano) #36

What are the values of FP.screen.width and FP.screen.height?

(John Andersson) #37

1664 & 960

If I send the game to my friend, when he runs it, the screen is black (so it works for him but not for me!?)

(Mike Evmm) #38

Hello,
is there a way to create an obstacle? Something like:

(Pardon the poor art skills)
If I understood correctly, Lit draws a black image over the stage and subtracts the “light images”, so I’m guessing it’s not possible to have an obstacle like this, but if so, can anyone point me in the right direction?

(Alex Larioza) #39

This method wont work with Lit because of the method it uses to draw the lights. To get a realistic lighting system as you described, you’d need to do ray casts from the light sources point of origin so that it stops if it hits anything “solid” before the light falls off.

(Mike Evmm) #40

Okay, thank you. Do you think it’d be possible to do it through ray casts using FP?

(Jacob Albano) #41

It’s definitely possible. Raycasting isn’t bound by any language or framework, it’s purely a set of algorithms. You can apply the theory to anything.